Nv 2452 tenant create + update a tenant sidebar #3863
Conversation
NV-2452 🏘️ [Tenant] Create a Tenant sidebar
What?Create Tenant sidebar will be shown after clicking on the "Add a Tenant" button located on the Tenants list page. Why? (Context)We need to display a sidebar when creating a new tenant and collect its name and identifier Definition of Done
|
…-2452-tenant-create-a-tenant-sidebar # Conflicts: # apps/web/src/pages/tenants/components/list/TenantsList.tsx
There was a problem hiding this comment.
Looks really great! :) left couple of question on place i was not sure and small race condition in the update page.
Do we need to store empty data object by default in the DB if the user did not provide custom data? maybe we could replace it with a placeholder?
Additionally, I noticed if the user deletes the empty object {} the create is not executed.
| @@ -14,6 +14,7 @@ export const inputStyles = (theme: MantineTheme) => { | |||
| }, | |||
| input: { | |||
| minHeight: '50px', | |||
| borderRadius: '7px', | |||
There was a problem hiding this comment.
this one won't break anything?
There was a problem hiding this comment.
No, all inputs should be with border-radius of 7px. But usually it was just the default from mantine
…-2452-tenant-create-a-tenant-sidebar # Conflicts: # apps/web/src/pages/tenants/components/list/TenantsList.tsx
…rn-data-as-a-prop fix: allow return 'data' as response prop
What change does this PR introduce?
Create Tenant sidebar will be shown after clicking on the "Add a Tenant" button located on the Tenants list page.
Tests will be added in a separate PR.
Why was this change needed?
Other information (Screenshots)